fix: file extension is not added to imported files when using NodeNext moduleResolution - #3361

packages/core/src/writers/schemas.ts (1)

225-227: 💤 Low value

Consider adding a clarifying comment for the fallback branch.

The fallback .replace(/\.ts$/, '') handles edge cases where relative doesn't end with fileExtension. Since canonical.importPath is constructed via getPath with fileExtension, the primary branch should handle most cases. A brief comment explaining when the fallback is needed would improve code clarity.

Example:

const withoutFileExtension = relative.endsWith(fileExtension)
  ? relative.slice(0, -fileExtension.length)
  : relative.replace(/\.ts$/, ''); // Fallback for legacy paths with hardcoded .ts extension

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/core/src/writers/schemas.ts` around lines 225 - 227, Add a short
clarifying comment on the fallback branch for the withoutFileExtension
computation: explain that relative.endsWith(fileExtension) handles normal paths
produced by getPath (used to build canonical.importPath) and the else branch
(relative.replace(/\.ts$/, '')) is a defensive fallback for legacy or hardcoded
".ts" paths that don't match the current fileExtension; place the comment next
to the else branch referencing withoutFileExtension, relative, fileExtension,
and canonical.importPath for context.

packages/core/src/utils/tsconfig.ts (1)

32-34: ⚡ Quick win

Incomplete extension mapping for NodeNext/Node16 module resolution.

The current implementation only converts .ts → .js for NodeNext/Node16 module resolution. According to TypeScript's module resolution rules, additional extensions should also be mapped:

• .tsx → .jsx
• .mts → .mjs
• .cts → .cjs

While Orval likely generates only .ts files currently, adding complete support makes this utility more robust and prevents edge-case bugs if other extensions are introduced later.

♻️ Proposed fix to handle all TypeScript extensions

  if (
    (module && NODE_NEXT_MODULES.has(module)) ||
    (moduleResolution && NODE_NEXT_MODULES.has(moduleResolution))
  ) {
-    return fileExtension.endsWith('.ts')
-      ? `${fileExtension.slice(0, -3)}.js`
-      : fileExtension;
+    if (fileExtension.endsWith('.ts')) {
+      return `${fileExtension.slice(0, -3)}.js`;
+    }
+    if (fileExtension.endsWith('.tsx')) {
+      return `${fileExtension.slice(0, -4)}.jsx`;
+    }
+    if (fileExtension.endsWith('.mts')) {
+      return `${fileExtension.slice(0, -4)}.mjs`;
+    }
+    if (fileExtension.endsWith('.cts')) {
+      return `${fileExtension.slice(0, -4)}.cjs`;
+    }
+    return fileExtension;
  }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/core/src/utils/tsconfig.ts` around lines 32 - 34, The current return
expression only maps `.ts`→`.js`; update the extension mapping logic (where
`fileExtension` is used) to handle the NodeNext/Node16 mappings as well:
`.ts`→`.js`, `.tsx`→`.jsx`, `.mts`→`.mjs`, and `.cts`→`.cjs` (e.g. replace the
simple slice with a small mapping or switch that checks `fileExtension` and
returns the corresponding mapped extension, leaving other extensions unchanged).